Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer complete #1134

Merged
merged 5 commits into from
Feb 17, 2022
Merged

Buffer complete #1134

merged 5 commits into from
Feb 17, 2022

Conversation

cole-h
Copy link
Contributor

@cole-h cole-h commented Nov 20, 2021

Closes #1043.

@cole-h cole-h force-pushed the buffer-complete branch 2 times, most recently from 48949ef to 99badb5 Compare November 20, 2021 21:21
archseer
archseer requested changes Nov 21, 2021
View reviewed changes
helix-term/src/ui/prompt.rs Outdated Show resolved Hide resolved
helix-term/src/ui/prompt.rs Show resolved Hide resolved
helix-term/src/ui/prompt.rs Outdated Show resolved Hide resolved
helix-view/src/lib.rs Outdated Show resolved Hide resolved
@cole-h
Copy link
Contributor Author

cole-h commented Dec 12, 2021

Thanks for all the feedback -- I'll likely get around to this in this upcoming weekend, but I've got finals coming up, so I won't have much time during the week. 🙏 I promise I haven't forgotten about this!

@archseer archseer mentioned this pull request Jan 3, 2022
Closed
cole-h and others added 5 commits February 17, 2022 12:25
@cole-h @archseer
helix-term/commands: display buffer id in picker
616f5c9
@cole-h @archseer
helix-term: implement buffer completer
1a119ac 
In order to implement this completer, the completion function needs to
be able to access the compositor's context (to allow it to get the
list of buffers currently open in the context's editor).
@cole-h @archseer
WIP: show all buffers that couldn't be closed
cb2eb95
@archseer
Pass through Editor instead of Context
cc1abb7
@archseer
Manually recalculate initial completion where it matters
3df2a30
@archseer archseer merged commit 24f90ba into helix-editor:master Feb 17, 2022
@cole-h cole-h deleted the buffer-complete branch February 17, 2022 21:14
@cole-h
Copy link
Contributor Author

cole-h commented Feb 17, 2022

Thanks for finishing this up! 🙇 I was really expecting to get back to this, but... after finals and work, I just wanted to chill and play the new FFXIV expansion (and then work and school started back up and now consume most of my free time).

Sorry for the lack of communication and dropping the ball, and thanks again for pushing this across the finish line ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer requested changes

@pickfire pickfire pickfire left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement buffer completer
3 participants
@cole-h @archseer @pickfire