Added workspace_symbol_picker

[EbbDrop]

closes #1009
Uses space > t to open a workspace wide symbol picker.

[sudormrfbin]

The start of an item gets truncated if it's too long, which hides the name of symbol (due to #951):

[EbbDrop]

I see two potential solutions:

1. Move the truncation to the other side for this picker but than we get the same problem as in File Picker: File names are trimmed if the path is too long #945:

Cell (src/m...
Cell (src/a...

2. Switch the file and symbol names:

...ain.rs: Cell
...elp.rs: Cell

But this does not look so good without truncation:

src/lib.rs: Cell
src/bin/main.rs: Cell

What solution would be preferred? Or does anybody have any other ideas.

[archseer]

Let's add a field pub truncate_start: bool to Picker. It should default to false, and leave it out of Picker::new parameters, then use it here:

helix/helix-term/src/ui/picker.rs

Line 569 in cf831b1

true,

This way you can initialize it like this:

let picker = Picker::new(...);
picker.truncate_start = true;
compositor.push(Box::new(picker))

By the way, what theme are you using? It looks like it's missing the picker border color, that's why it's blue.

[archseer]

We probably want to set this flag on the other symbol picker too. I'm also wondering whether the key should be space+S to match the other picker maybe?

[EbbDrop]

I and the other symbol picker uses FilePicker at the moment. Should i also add the truncate_start field to FilePicker?
ps.
I am using the gruvbox theme edited to have a transparent background but the blue is still there without my edits.

[archseer]

You can keep FilePicker as is since we always want to show the end of the file path there.

[EbbDrop]

FilePicker is used at the moment for all the pickers since it also gives the file preview to the left. So I think it is FilePicker that should get the change to have a truncate_left option.

[archseer]

Ah sorry, I confused it with the file_picker method. Yeah, you'll need to add this to both FilePicker and Picker

[EbbDrop]

Moved the truncation to the other side for both pickers and changed the shortcut to space+S

[sudormrfbin]

LGTM, tested with rust-analyzer. There's also a merge conflict btw.

[EbbDrop]

Fixed typo and merge conflict

[archseer]

Thanks! 🎉