Panic in vsplit, goto_file_vsplit (Tree::recalculate)

[trink]

Set the terminal size, so the number of splits to cause the failure is
consistent.

stty rows 24 cols 80
hx test_document.txt

Test Document

a
b
c
d
e
f
g
h
i

Steps to Reproduce

1. % # select_all
2. Alt-s # split_selection_on_newline
3. Ctrl-W F # goto_file_vsplit

Release

thread 'main' panicked at 'index out of bounds: the len is 1920 but the index is 1920', helix-tui/src/buffer.rs:517:17

Debug

thread 'main' panicked at 'attempt to subtract with overflow', helix-view/src/tree.rs:407:50

Description

The window area height calculation goes negative (overflows) when there are more windows than will fit in the display area.

Related Bugs and PRs

#1084 #4642

[pascalkuthe]

this is a duplicate of #1083

[l4l]

Actually it is not duplicate. The tabs have sufficient space for that: 10 tabs -> 80pxs.

[pascalkuthe]

hmm but that other issue is not about "crash when there is not enough space to render all splits" but just "opening a large number of vsplits causes a crash" so the exact number doesn't matter. And your patch also fixes that issue too so its really the same thing.

[l4l]

#1083 still reproduces with my patch if nums of tabs > pixel width. I think the proper fix for it is #4642