Theming: Cursor/Selection foreground does not override rendered whitespace.

[levitatingpineapple]

Summary

Currently any colors set on ui.virtual.whitespace are unaffected by colors of the cursor.* and ui.selection

While I see how this might be intentional, I think it has few issues:

• It does not play well with reversed modifier
• Any theme that sets both bg and fb won't have cursor or selection visible over rendered whitespace.

Reproduction Steps

Consider this dummy theme:

"ui.selection" = { fg = "red", bg = "blue", modifiers = ["reversed"] }
"ui.virtual.whitespace" = "green"

I expected this to happen the background of the selection would be red:

Instead, the background of the selection is red or green, depending character type:

Platform

macOS

Terminal Emulator

alacritty/iTerm

Installation Method

brew

Helix Version

helix 23.10 (f6021dd)

[kirawi]

Duplicate of #5675