Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ad-hoc hooks to use the event system #9629

Open
5 of 10 tasks
the-mikedavis opened this issue Feb 14, 2024 · 1 comment
Open
5 of 10 tasks

Refactor ad-hoc hooks to use the event system #9629

the-mikedavis opened this issue Feb 14, 2024 · 1 comment
Labels
A-helix-term Area: Helix term improvements A-language-server Area: Language server client A-vcs Area: Version control system interaction C-enhancement Category: Improvements E-medium Call for participation: Experience needed to fix: Medium / intermediate

Comments

@the-mikedavis
Copy link
Member

the-mikedavis commented Feb 14, 2024 •
edited
Loading

This is meant to be a tracking issue for refactoring existing ad-hoc hooks to use the event system introduced in #8021.
@the-mikedavis the-mikedavis added C-enhancement Category: Improvements A-language-server Area: Language server client A-helix-term Area: Helix term improvements E-medium Call for participation: Experience needed to fix: Medium / intermediate A-vcs Area: Version control system interaction labels Feb 14, 2024
@the-mikedavis the-mikedavis mentioned this issue Feb 15, 2024
Closed
@pascalkuthe
Copy link
Member

we may also want to update mapping diagnostic change (and inlay hint mapping and so forth) to use the event system. Really most of the custom code in apply_impl could be moved there.

This was referenced Feb 17, 2024
Merged
Merged
@pascalkuthe pascalkuthe mentioned this issue Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements A-language-server Area: Language server client A-vcs Area: Version control system interaction C-enhancement Category: Improvements E-medium Call for participation: Experience needed to fix: Medium / intermediate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@the-mikedavis @pascalkuthe