Document diagnostics are not reported in the buffer (but visible in the workspace picker)

[kirawi]

Summary

It seems like one of the recent commits cause us to not be able to report the diagnostics associated with a file in the buffer on Windows.

Reproduction Steps

I tried this:

1. hx in helix
2. Wait for LSP to finish initializing
3. Open document.rs
4. Go to line 956 where there is a cfg disabled diagnostic.

I expected this to happen:

Diagnostic is shown in the diagnostic and upper right corner as usual.

Instead, this happened:

]d and [d do not work. Going to line 956 where the error is shows nothing in the gutter nor does the error appear.

Helix log

~/.cache/helix/helix.log

log.txt

Platform

Windows

Terminal Emulator

Windows Terminal 1.18.3181.0

Installation Method

Source

Helix Version

2661e05

[the-mikedavis]

#8873 was relatively recent and overhauled the way Document's diagnostics field is handled, which powers the gutter and diagnostics rendering. It's odd that this only affects Windows though.

[pascalkuthe]

Could also be #7658 maybe?

[pascalkuthe]

@kirawi are you sure that it was one of the recetn commits. If you look trough the looks you will see that the casing of the drieletter is causing the problem. Its uppercase internally4 but RA sends a lowercase drive letter. That is exactly what #3267 is about and #7367 would fix

[pascalkuthe]

that issue has been around forever

[kirawi]

Yeah that's what I thought too, but the latest commit was working a couple of weeks ago. It was reported on Matrix that 23.10 works: https://matrix.to/#/!zMuVRxoqjyxyjSEBXc:matrix.org/$BFNFaPLZCR6_4pL3RY9TDOpPrYyJ0yJeI7tJk_EfSO0?via=matrix.org&via=mozilla.org&via=envs.net

I should have checked 23.10 on Windows myself so I'll do that when I'm back on. It's possible that it's either something to do with my local environment, a Windows update, or something with Helix.

[kirawi]

I checked and it's indeed #8873

[pascalkuthe]

Ah I see now that PR causes #3267 to trigger more reliably. It's not a bug in that PR it just exacerbates an existing issue with an existing fix.

Closing as duplicate of #3267