Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silent deletion of log files generated with helix -vvv ir.cpp, when opening them with helix #941

Closed
matu3ba opened this issue Oct 31, 2021 · 4 comments · Fixed by #1130
Closed
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug

Comments

@matu3ba
Copy link

matu3ba commented Oct 31, 2021

Reproduction steps

wget https://github.com/ziglang/zig/blob/master/src/stage1/ir.cpp
hx -vvv ir.cpp

Environment

  • Platform: Linux pc 5.14.14
  • Helix version: v0.5.0-16-g592fba1

The log file is 1.2 MB, so I compressed it.

What is happening:

[user@pc stage1]$ hx -vvv ir.cpp
[user@pc stage1]$ cd ~/.cache/helix/
[user@pc helix]$ l
helix.log
[user@pc helix]$ du
 1.2M   ┌── helix.log
 1.2M ┌─┴ .
[user@pc helix]$ cp helix.log helix_back.log
[user@pc helix]$ hx helix.log
[user@pc helix]$ du .
   0B   ┌── helix.log
 1.2M   ├── helix_back.log
 1.2M ┌─┴ .

accidentically I opened the issue as question in tree-sitter repo, but at least I also filed there one bug.

@matu3ba matu3ba added the C-bug Category: This is a bug label Oct 31, 2021
@matu3ba
Copy link
Author

matu3ba commented Oct 31, 2021

helix_back.zip

@kirawi
Copy link
Member

kirawi commented Oct 31, 2021

#735 I didn't consider that would happen, hmm. Maybe that change should just be reverted.

@kirawi kirawi added the A-helix-term Area: Helix term improvements label Oct 31, 2021
@archseer
Copy link
Member

archseer commented Nov 2, 2021

Yeah, we should get rid of truncation. Helix doesn't log much anymore unless ran with -v so it should be fine.

@WindSoilder
Copy link
Contributor

WindSoilder commented Nov 19, 2021

What about truncate only when run with -v, otherwise keep the log open? If no truncate and run with -v again and again, the log file can be large (though I think user won't do this often)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants