Language server config is not updated for :lsp-restart after :config-reload

[kirawi]

Summary

This behavior seems to stem from howsyn_loader is replaced rather than the interior value being replaced:

helix/helix-term/src/application.rs

Lines 383 to 388 in 9c56afe

	fn refresh_language_config(&mut self) -> Result<(), Error> {
	let syntax_config = helix_core::config::user_syntax_loader()
	.map_err(|err| anyhow::anyhow!("Failed to load language config: {}", err))?;
	self.syn_loader = std::sync::Arc::new(syntax::Loader::new(syntax_config));
	self.editor.syn_loader = self.syn_loader.clone();

combined with us not updating the value for Registry as well. I think we could use ArcSwap here like we do for the config.

Reproduction Steps

1. Open the helix repo in Helix and open a document.
2. Add a custom language config for rust-analyzer.
3. :config-reload and :lsp-restart

Helix Version

9c56afe

[rgunindi]

I had the problem that lsp reactivated many times after :lsp-restart command, so I was looking for issues.

[ferntheplant]

I'm still running into this issue with reloading the ltex-ls LSP server. If I update my languages.toml manually to add a new word like "asdfg" to the spellcheck dictionary. Then when I run :config-reload followed by :lsp-restart the LSP server still warns me about misspelling "asdfg". However if I quit helix and reopen the file then the spell check config is applied correctly