Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Unsupported errors when enabling bracketed paste #9336

Closed
kirawi opened this issue Jan 14, 2024 · 3 comments
Closed

Handle Unsupported errors when enabling bracketed paste #9336

kirawi opened this issue Jan 14, 2024 · 3 comments
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR

Comments

@kirawi
Copy link
Member

kirawi commented Jan 14, 2024

The error comes from here when we setup the terminal:

execute!(
self.buffer,
terminal::EnterAlternateScreen,
EnableBracketedPaste,
EnableFocusChange
)?;

To prevent the exit on startup we could handle the Unsupported error from crossterm (https://github.com/crossterm-rs/crossterm/blob/08762b3ef4519e7f834453bf91e3fe36f4c63fe7/src/event.rs#L390-L395) instead and log that helix won't be able to use bracketed paste

Originally posted by @the-mikedavis in #9025 (reply in thread)

@kirawi kirawi added C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much A-helix-term Area: Helix term improvements E-good-first-issue Call for participation: Issues suitable for new contributors E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR labels Jan 14, 2024
@jigypeper
Copy link
Contributor

I have made an attempt, but no permissions to push to a branch

@jigypeper
Copy link
Contributor

need to fork it?

@kirawi
Copy link
Member Author

kirawi commented Jan 18, 2024

Closed by #9353

@kirawi kirawi closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR
Projects
None yet
Development

No branches or pull requests

2 participants