Crash when editing markdown

[rgasper]

Summary

I'm frequently encountering crashes when editing markdown files. It seems to maybe have something to do with code blocks in particular, but I'm not sure.

This seems similar to #8821

Reproduction Steps

• Opened a markdown file hx README.md:
• added contents like:
  • (sorry this isn't raw text - I'm not sure how to do a markdown code block with code blocks inside...

Header

some text
some text

Header2

do a thing:

import pandas as pd
df = pd.DataFrame({'a':1})

It doesn't immediately crash on edit, but this is happening often. Crash has happened to me both in normal mode and in insert mode. Has occurred on markdown files approximately this short. It seems to occur in moments when the python syntax inside the code blocks is invalid syntax, but the syntax error is in the middle of the block (not the end).

Helix log

~/.cache/helix/helix.log

I'm not clear these error messages are associated with the crash, but they happened around the same time.

2023-12-05T14:26:59.427 helix_lsp::transport [ERROR] Tried sending response into a closed channel (id=Num(350)), original request likely timed out
...
2023-12-05T15:02:07.709 helix_view::editor [ERROR] Failed to initialize the language servers for `source.md` - `marksman` { cannot find binary path }
2023-12-05T15:04:02.831 helix_view::editor [ERROR] Failed to initialize the language servers for `source.md` - `marksman` { cannot find binary path }
2023-12-05T15:10:58.277 helix_view::editor [ERROR] editor error: Register [@] empty
2023-12-05T15:16:38.485 helix_view::editor [ERROR] Failed to initialize the language servers for `source.md` - `marksman` { cannot find binary path }

Platform

macOS

Terminal Emulator

kitty

Installation Method

brew

Helix Version

helix 23.10 (f6021dd)

[the-mikedavis]

What does the panic message say? Or by crash do you mean that Helix is hanging? This might be #8709 if it's a hang

[rgasper]

it's a hang - terminal freezes, accepts no inputs

[pascalkuthe]

then its almost certainly a duplicate of #8709. This is abug in tree-sitter not in helix. If you switch to the helix master branch the bug is fixed because we use an unreleaesd version of TS with a relevant fix. We just can't do that in official release because package mangers can't deal with that

[the-mikedavis]

Let's close as a duplicate of #8709

[chtenb]

then its almost certainly a duplicate of #8709. This is abug in tree-sitter not in helix. If you switch to the helix master branch the bug is fixed because we use an unreleaesd version of TS with a relevant fix. We just can't do that in official release because package mangers can't deal with that

@pascalkuthe My personal helix branch is branched off of origin/master from 5 weeks ago, but I'm still experiencing the bug. Would I need to do something special to get the TS fix other than just checking it out and recompiling?

[pascalkuthe]

it should be automatically fixed, if you have a small reproduction case you can open an issue with that

[chtenb]

The same reproduction as in #8821, i.e. open a list with three nesting levels and the crash is imminent.

[pascalkuthe]

That is a seperate issue and hence that issue is still open (with a way described to fix it). It has nothing to do with this issue (which is about an endless loop/freeze)

[chtenb]

My apologies, I misinterpreted the comments in this thread it seems.