Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep LSP diagnostics at least until some new ones arrive. #8858

Closed
dpc opened this issue Nov 19, 2023 · 1 comment
Closed

Keep LSP diagnostics at least until some new ones arrive. #8858

dpc opened this issue Nov 19, 2023 · 1 comment
Labels
C-enhancement Category: Improvements

Comments

@dpc
Copy link
Contributor

dpc commented Nov 19, 2023

I'm working on a large Rust project. I make some refactoring changes that break existing callers. I hit :w and CPU's temperature rapidly increases. I wait and wait... I get over 9000 errors.

I fix some in one file and :w. LSP makes my laptop fan go jet engine mode again. I wait. I could be fixing some other errors already, because I know there's still plenty off them, but Helix decided to reset the previous list and <space>D shows an empty picker. Bummer.

I wish Helix kept the previous LSP diagnostics longer. At least until new LSP run doesn't complete or start returning something actionable again.

@dpc dpc added the C-enhancement Category: Improvements label Nov 19, 2023
@pascalkuthe
Copy link
Member

There is nothing we can do about this, raise an issue with rust-analyzer. We absolutely do keep diagnostics until the next publishDiagnostic arrives (and map them trough the changes something that vscode doesn't do and that #6447 improves upon further). It's just that RA immidietly discards all checkOnSave diagnostics on save and therefore sends an empty list.

This is indistinguishable for us from the diagnostics actually being fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

2 participants