Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Palette Shows Preview #8665

Closed
exastone opened this issue Oct 30, 2023 · 3 comments · Fixed by #8667
Closed

Command Palette Shows Preview #8665

exastone opened this issue Oct 30, 2023 · 3 comments · Fixed by #8667
Labels
C-enhancement Category: Improvements E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR

Comments

@exastone
Copy link

Small UX enhancement request.
The default for pickers is to show preview, however this isn't a sensible default for the command palette picker.
Is there a way to distinguish between different pickers to change the default for showing the preview split for command palette picker and file picker?

@exastone exastone added the C-enhancement Category: Improvements label Oct 30, 2023
@the-mikedavis
Copy link
Member

This should be a small fix. Here:

let render_preview = self.show_preview && area.width > MIN_AREA_WIDTH_FOR_PREVIEW;

We should also check that the picker has a preview function:

let render_preview = self.show_preview && self.file_fn.is_some() && area.width > MIN_AREA_WIDTH_FOR_PREVIEW;

@Utshaan
Copy link

Utshaan commented Feb 28, 2024

Issue is said to be fixed in version 23.10, and I am facing this issue with that same version

@the-mikedavis
Copy link
Member

This isn't included in 23.10. 23.10 was cut on 2023-10-24 and #8667 was merged on 2023-10-30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants