Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration override does not work for rulers #8100

Closed
connortsui20 opened this issue Aug 28, 2023 · 1 comment
Closed

Configuration override does not work for rulers #8100

connortsui20 opened this issue Aug 28, 2023 · 1 comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug R-duplicate Duplicated issue: please refer to the linked issue

Comments

@connortsui20
Copy link
Contributor

When trying to override a ruler setting in the .helix/config.toml, it appends the rulers instead of overriding.

I don't think this should be considered correct behavior because 1) you likely don't have more than 3 rulers set up and it should be easy to add rulers manually and 2) as far as I know there is no way to locally remove a ruler that is set in the global config.

Maybe there is another way to do this but if not, here is the issue.

Example:

# ~/.config/helix/config.toml
[editor]
rulers = [101]
# {dir}/.helix/config.toml
[editor]
rulers = [121]

The above results in 2 separate rulers, and I think the correct behavior should be for the local ruler setting to completely override the rulers instead of appending.

@kirawi kirawi added E-easy Call for participation: Experience needed to fix: Easy / not much A-helix-term Area: Helix term improvements E-good-first-issue Call for participation: Issues suitable for new contributors C-bug Category: This is a bug labels Apr 5, 2024
@pascalkuthe
Copy link
Member

this caused by the way we merge configs right now, this will be fixed by #9318.

Closing as this falls under #8853 and is a know issue that we don't need to track seperatly

@pascalkuthe pascalkuthe closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2024
@pascalkuthe pascalkuthe added R-duplicate Duplicated issue: please refer to the linked issue and removed E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug R-duplicate Duplicated issue: please refer to the linked issue
Projects
None yet
Development

No branches or pull requests

3 participants