Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an alternative default theme for 16 color terminals #791

Closed
Omnikar opened this issue Sep 29, 2021 · 5 comments
Closed

Create an alternative default theme for 16 color terminals #791

Omnikar opened this issue Sep 29, 2021 · 5 comments
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors

Comments

@Omnikar
Copy link
Contributor

Omnikar commented Sep 29, 2021

#699 is merged, so Helix now supports 16 color themes, but there currently don't exist any that ship with the editor. Since, if a user is using a 16 color terminal, they wouldn't be able to use the default theme, I think it could be a good idea to create a 16 color theme and embed it in the editor just like the default theme, and then, if the user doesn't have a theme configured, detect whether their terminal supports full color, and use the 16 color alternate default theme if it doesn't.

@Omnikar Omnikar added the C-enhancement Category: Improvements label Sep 29, 2021
@kirawi kirawi added A-theme Area: Theme and appearence related E-easy Call for participation: Experience needed to fix: Easy / not much labels Sep 29, 2021
@pickfire
Copy link
Contributor

pickfire commented Oct 1, 2021

A use case for this is when using helix in linux console (tty).

@raygervais
Copy link
Contributor

I'd like to try this out, leveraging sources such as http://chriskempson.com/projects/base16/ I figure adding base16-default-dark and base16-eighties would make good additions.

Will prob reach out regarding the best spot to look / update for the second ask, which is detecting the environment and switching themes.

@MaxVerevkin
Copy link

Another use case: if I understood correctly, changing terminal theme would immediately change the editor theme. For example, terminal can automatically switch to dark theme when needed, and it would be nice if helix switched too.

@archseer
Copy link
Member

Fixed in #1078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants