Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commenting code within JSX blocks uses incorrect comment format #7731

Closed
TheAndrewJackson opened this issue Jul 24, 2023 · 1 comment
Closed
Labels
C-bug Category: This is a bug R-duplicate Duplicated issue: please refer to the linked issue

Comments

@TheAndrewJackson
Copy link

Summary

The normal typescript and javascript comment syntax (//) is correctly applied in standard ts/js. JSX markup inside ts/js files requires block comments within curly braces ({/* */}). <C-c> is applying the normal syntax (//) inside JSX blocks.

Reproduction Steps

commenting.in.JSX.mov

I tried this:

  1. hx file-with-jsx-markup.tsx
  2. create a react component with a minimal render function
  3. try commenting out some text within the JSX markup <C-c>

I expected this to happen:
4. the code is commented out with the block syntax {/* */}

Instead, this happened:
4. the code is commented out with the standard syntax //

Helix log

~/.cache/helix/helix.log
The log file was empty

Platform

macOS

Terminal Emulator

kitty 0.25.0

Helix Version

helix 23.05 (7f5940b)

@TheAndrewJackson TheAndrewJackson added the C-bug Category: This is a bug label Jul 24, 2023
@the-mikedavis
Copy link
Member

Duplicate of #1505

See #6832

@the-mikedavis the-mikedavis closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2023
@the-mikedavis the-mikedavis added the R-duplicate Duplicated issue: please refer to the linked issue label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug R-duplicate Duplicated issue: please refer to the linked issue
Projects
None yet
Development

No branches or pull requests

2 participants