Underline ignores its color

[st0rmbtw]

Summary

Underline ignores its color and uses the color of a word.

Reproduction Steps

I tried this:

In mytheme.toml:

"diagnostic.error" = { fg = "blue", underline = { color = "red", style = "curl"} }

I expected this to happen:
The color of the underline is red, the color of the word is blue

Instead, this happened:
The color of the underline is blue and the color of the word is also blue

Helix log

No response

Platform

Windows

Terminal Emulator

Windows Terminal, Alacritty

Helix Version

helix 23.05 (7f5940b)

[gabydd]

Can you try setting

[editor]
undercurl = true

To force undercurl it seems that the curly underline isn't showing up at all

[st0rmbtw]

@gabydd Nope, it didn't help

[gabydd]

In config.toml:

theme changes need to be done in a theme file, see making a theme https://docs.helix-editor.com/themes.html#creating-a-theme

you can use inherits = "<theme you want to change>" in that file to override the underline of a specific theme

[st0rmbtw]

@gabydd Oh, I meant to write mytheme.toml not config.toml. I'm going to edit the description.

[A-Walrus]

I was unable to reproduce, tried on Alacritty but I got the expected results.

[CptPotato]

If I remember correctly this is a Windows thing. The underline colors and styles get ignored (and filtered out) by conpty, so there's nothing that helix or even the terminal emulator can do.

[gabydd]

That makes sense that it is a terminal issue, if it is not you should be able see the curly underline on most themes, cause almost all of them use it

[kirawi]

microsoft/terminal#7228

[gabydd]

This also affects alacritty on windows, so it can probably be marked as upstream and closed

[st0rmbtw]

Yep, it's a Windows's fault, works on Linux as expected. Should I close this issue?

[A-Walrus]

Leave it open, in case someone else runs into it

[andradei]

Leave it open, in case someone else runs into it

Like me. I can also confirm it's broken on Windows but not on Linux.

[nkitsaini]

Interestingly I have the issue on Linux with Alacrity using tmux i.e. the undercurl color is derived from syntax highlighting instead of the predefined red. The color is accurate (red) if I am not inside tmux. I did verify that this is not due to some environment variable by syncing the env variables in both non-tmux and tmux session.

Also I have tried setting undercurl in config to no help.

[nkitsaini]

Update: I was able to get undercurl color working correctly on tmux by following suggestion at: https://old.reddit.com/r/neovim/comments/vqbu8m/undercurl_support_on_different_terminals/ieoxghg/

Specifically enabling coloring by adding following to ~/.tmux.conf

set -as terminal-overrides ',*:Smulx=\E[4::%p1%dm'  # undercurl support
set -as terminal-overrides ',*:Setulc=\E[58::2::%p1%{65536}%/%d::%p1%{256}%/%{255}%&%d::%p1%{255}%&%d%;m'  # underscore colors - needs tmux-3.0