Typing text offsets diagnostics that are after text typed

[Omnikar]

https://asciinema.org/a/8zyizvoNTUMkDhhzeaS10qw0W

I presume this is probably because of char indexing for the diagnostics.

[archseer]

I did initially map diagnostics through edits to prevent this (updating the positions), but I noticed that rust-analyzer would unhelpfully re-send the wrong offsets immediately, undoing the work.

[archseer]

(It'll fix the positions after you save and it re-runs the checks)

[archseer]

Commented out code:

helix/helix-view/src/document.rs

Lines 638 to 646 in 7e11236

	// map state.diagnostics over changes::map_pos too
	// NOTE: seems to do nothing since the language server resends diagnostics on each edit
	// for diagnostic in &mut self.diagnostics {
	// use helix_core::Assoc;
	// let changes = transaction.changes();
	// diagnostic.range.start = changes.map_pos(diagnostic.range.start, Assoc::After);
	// diagnostic.range.end = changes.map_pos(diagnostic.range.end, Assoc::After);
	// diagnostic.line = self.text.char_to_line(diagnostic.range.start);
	// }

[kirawi]

Is there anything that can be done about it?

[kirawi]

Looks like we're not getting PublishDiagnosticsParams w/ any whitespace (including comments).

[archseer]

Turns out this is a known rust-analyzer issue: rust-lang/rust-analyzer#8836

[gabydd]

correct me if I am wrong but I think this is fixed on master

[the-mikedavis]

I think this still happens unless it was fixed in a recent rust-analyzer version. From what I understand this is caused by rust-analyzer sending out-of-date/cached ranges in publishDiagnostic which undoes the work we do within helix for updating ranges rust-lang/rust-analyzer#10628 (comment)