Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

% should add to the jump list #6780

Closed
antoyo opened this issue Apr 16, 2023 · 3 comments
Closed

% should add to the jump list #6780

antoyo opened this issue Apr 16, 2023 · 3 comments
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@antoyo
Copy link
Contributor

antoyo commented Apr 16, 2023

Hi.
Due to vim muscle memory, I often press % instead of mm, but the problem is that this jumps to the end of the file, so I often want to go back to where I was with Ctrl-O, but this doesn't work.
I suggest % adds to the jump list in order to be able to go back with Ctrl-O.
Thanks.

@antoyo antoyo added the C-enhancement Category: Improvements label Apr 16, 2023
@cole-h
Copy link
Contributor

cole-h commented Apr 17, 2023

I opened a simple PR that appears to fix this for me: #6783

@kirawi kirawi added the A-helix-term Area: Helix term improvements label Apr 17, 2023
@the-mikedavis
Copy link
Member

I think this is better addressed by #6695 or #1596. You can keybind around it in the meantime:

# ~/.config/helix/config.toml
[keys.normal]
"%" = ["push_selection", "select_all"]

I don't want to see % add to the jumplist: depending on your workflow % can be really common to use (for example for replacing all regex matches around a document) and pushing to the jumplist for every % would make too many jump points.

@antoyo
Copy link
Contributor Author

antoyo commented Apr 17, 2023

Thanks.

For people finding this issue, the command is save_selection, not push_selection.

@antoyo antoyo closed this as completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants