Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment and Decrement Behavior When No Number Under Selection #5928

Closed
Aesthetikx opened this issue Feb 11, 2023 · 2 comments · Fixed by #5929
Closed

Increment and Decrement Behavior When No Number Under Selection #5928

Aesthetikx opened this issue Feb 11, 2023 · 2 comments · Fixed by #5929
Labels
A-documentation Area: Documentation improvements C-bug Category: This is a bug

Comments

@Aesthetikx
Copy link
Contributor

While going through the tutor, I came across "Note: If there isn't a number under the selection the cursor will jump to the next number in the line and act on it". On master, this does not appear to be the case, so it is either a bug or the tutor text should be updated.

@the-mikedavis
Copy link
Member

That behavior was intentionally removed in #4123 but it looks like we forgot to update the tutor. That line is here:

helix/runtime/tutor

Lines 833 to 834 in 3b301a9

Note: If there isn't a number under the selection the cursor
will jump to the next number in the line and act on it.

Would you like to open a PR to fix this? We should remove those two lines (and replace them with blank lines to keep the number of rows in each section the same).

@the-mikedavis the-mikedavis added C-bug Category: This is a bug A-documentation Area: Documentation improvements labels Feb 11, 2023
@Aesthetikx
Copy link
Contributor Author

Well, I guess I'm a contributor now! First real world usage of helix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: Documentation improvements C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants