gf misbehaves on paths surrounded by quotes

[theteachr]

Summary

When the cursor is on (not selected, on a single char) a path surrounded quotes followed by a comma, pressing gf opens a buffer pointing to a weird path.

Example scene

application_config_map = {
    "kitty": "kitty/.config/kitty/kitty.conf",
    # .................^.....
    "helix": "helix/.config/helix/config.toml",
    "nvim": "nvim/.config/nvim/init.lua",
}

With cursor at the ^ marker (no selection), pressing gf opens a buffer with kitty/.config/kitty/kitty.conf", as the path.

Reproduction Steps

• In an open buffer, type a path name: .config/helix
• Surround the path with quotes: '.config/helix'
• Add a comma at the end: '.config/helix',
• Place the cursor anywhere on the path name (not on the quote, no selection)
• Press gf
• The opened buffer will have a path name like .config/helix,

Helix log

No response

Platform

macOS

Terminal Emulator

kitty 0.26.5

Helix Version

helix 22.12 (e2a1a97)

[ghost]

I looked at the code and found out this lines:

helix/helix-term/src/commands.rs

Lines 1051 to 1059 in b633139

	// Trims some surrounding chars so that the actual file is opened.
	let surrounding_chars: &[_] = &['\'', '"', '(', ')'];
	paths.clear();
	paths.push(
	current_word
	.fragment(text_slice)
	.trim_matches(surrounding_chars)
	.to_string(),
	);

The problem is not with quotes, but with the comma. I added a comma as another separator and it works.

let surrounding_chars: &[_] = &['\'', '"', '(', ')', ','];

However, I think it's more like hotfix and not desire solution. What do you say (question to maintainers)? Would this be an acceptable solution or should it only remove the comma if it is at the end of the selection?

[pascalkuthe]

Closed by #9065