Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Devcontainers support #5454

Closed
IgnisDa opened this issue Jan 9, 2023 · 4 comments
Closed

[feature] Devcontainers support #5454

IgnisDa opened this issue Jan 9, 2023 · 4 comments
Labels
C-enhancement Category: Improvements

Comments

@IgnisDa
Copy link

IgnisDa commented Jan 9, 2023

Hello. Thank you developers and awesome project!

It would be really great if helix support developing in devcontainers (either in core or via plugins). A lot of developers prefer not to clutter their systems with language tools (like rust-analyzer), and devcontainers does really well in addressing.

Looking at it from a surface level, it should be doable. Devcontainers has a CLI that can be packaged and installed once this PR lands.

Helix itself can be run similar to how their vim example works.

Would be great if you could tell me the viability of this feature. Thanks!

@IgnisDa IgnisDa added the C-enhancement Category: Improvements label Jan 9, 2023
@kirawi
Copy link
Member

kirawi commented Jan 9, 2023

Duplicate of #3002

@kirawi kirawi marked this as a duplicate of #3002 Jan 9, 2023
@kirawi kirawi closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2023
@kirawi kirawi added the R-duplicate Duplicated issue: please refer to the linked issue label Jan 9, 2023
@IgnisDa
Copy link
Author

IgnisDa commented Jan 9, 2023

@kirawi The above issue runs the LSP inside a container. The feature I want support for runs Helix in the container too. Thus I do not think this is a duplicate.

@IgnisDa
Copy link
Author

IgnisDa commented Jan 9, 2023

After some hacking, here is the progress I made:

  • The base image is taken from this branch
  • The changes required to my existing devcontainer are in this branch

To get it running, clone the repo in step 1, checkout the correct branch and then run the command in docker/README.md. Then clone repo in step 2, checkout correct branch and run ./.helix/start.sh. It will prompt you for a password, type password there and helix should run. I have already installed rust-analyzer in the image so the project should open up with a working LSP.

Things that need to be figured out here:

  • Remove password prompt. The scripts are taken from here but the password prompt still comes up. (fixed in IgnisDa/rust-libs@043bb64)
  • Figure out how to forward github credentials. Forwarding SSH credentials seem to be straightforward (tutorial here). But I use gh auth login and would like the same credentials to work.

@kirawi kirawi reopened this Jan 9, 2023
@kirawi kirawi removed the R-duplicate Duplicated issue: please refer to the linked issue label Jan 9, 2023
@kirawi kirawi marked this as not a duplicate of #3002 Jan 9, 2023
@IgnisDa
Copy link
Author

IgnisDa commented Jan 11, 2023

I made a pubic gist with info on how to get basic devcontainer support working: https://gist.github.com/IgnisDa/f4c1ffb3b798686df3193a80cbd5b3eb.

@helix-editor helix-editor locked and limited conversation to collaborators Apr 7, 2024
@pascalkuthe pascalkuthe converted this issue into discussion #10248 Apr 7, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

2 participants