Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to cycle through signature help signatures #5403

Closed
Kenneth-Mata opened this issue Jan 4, 2023 · 7 comments · Fixed by #9974
Closed

Option to cycle through signature help signatures #5403

Kenneth-Mata opened this issue Jan 4, 2023 · 7 comments · Fixed by #9974
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@Kenneth-Mata
Copy link

I'm using omnisharp and i get the documentation popup which shows the documentation for the main implementation of the method but there doesn't seem to be a way to cycle through the different overloads.

2023-01-04_14-18

@Kenneth-Mata Kenneth-Mata added the C-enhancement Category: Improvements label Jan 4, 2023
@the-mikedavis
Copy link
Member

As far as I know the LSP spec does not support this. Does this work in any other editor you have tried?

@Kenneth-Mata
Copy link
Author

i'll check out in emacs with eglot and see, feels very odd if the spec does not support it

@Kenneth-Mata
Copy link
Author

As far as I know the LSP spec does not support this. Does this work in any other editor you have tried?

Looking around at this issue in lsp-mode (one lsp implementation for emacs) eglot does seem to do so, or at least doing so using signature help

@the-mikedavis
Copy link
Member

Ah interesting, I bet those are keybindings to cycle through the signatures list: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#signatureHelp

That would also be useful for languages with variadic functions where you might want to see a signature for a function with higher arity

@the-mikedavis the-mikedavis added the A-helix-term Area: Helix term improvements label Jan 6, 2023
@the-mikedavis the-mikedavis changed the title Option to cycle through overloaded versions of a method Option to cycle through signature help signatures Jan 6, 2023
@Kenneth-Mata
Copy link
Author

Was curious how is this one going, today i happened to be looking at neovim and instead of cycling through the different signatures, they just call the full list and display it

@jabcross
Copy link

jabcross commented Dec 1, 2023

It works fine on VSCode with clangd, giving you the ability to cycle through the implementations with the up and down arrow keys. Is this currently in the roadmap? I am interested in implementing this, as it's one of the only sticking points preventing me from adopting helix for my C++ work.

image

@Armando-CodeCafe
Copy link

Bumping this because in csharp this is quite a hassle to constantly have to google the documentation of certain functions just to find out the overloads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants