Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make primary selection/cursor stand out in default theme? #5281

Closed
xJonathanLEI opened this issue Dec 24, 2022 · 2 comments
Closed

Make primary selection/cursor stand out in default theme? #5281

xJonathanLEI opened this issue Dec 24, 2022 · 2 comments
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements

Comments

@xJonathanLEI
Copy link
Contributor

I think the default theme can use some improvements regarding selection/cursor colors:

1. Primary selection/cursor uses the same color as other selections

Primary selection/cursor vs others are indistinguishable right now. It's impossible to tell which selection is the primary one. Ideally we should make the primary selection stand out with a brighter color.

2. Cursor color too jumpy

Currently the cursor color is set to reversed. While this is convenient from a theme authoring standpoint, it changes so often that it fails to give a consistent impression on what the primary cursor should look like. I suggest using a fixed color for the primary cursor, and a slightly less bright color for non-primary ones.

Actually, it's impossible to fix issue 1 without getting rid of the use of reversed here.

@xJonathanLEI xJonathanLEI added the C-enhancement Category: Improvements label Dec 24, 2022
@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label Dec 24, 2022
@archseer
Copy link
Member

Yeah this was discussed here: #3842

I was trying to find a good theme setting but couldn't settle on anything. Making it work with reverse will be easier once we land #5130

@xJonathanLEI
Copy link
Contributor Author

Ah sorry I'm closing this as a duplicate of #3842 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

3 participants