diff.plus, diff.minus and diff.delta theme keys need updating for many themes for git gutters

[David-Else]

Since git gutters landed #3890 many themes need the diff colors updating, I have taken screen shots of the ones I consider in obvious need of attention, but appreciate some changes may be subjective.

*EDIT There is also "diff.delta.moved" to consider, I missed that, I am not sure if it is needed?
*EDIT Theme authors, a new release of Helix is planned this weekend, so please make any changes you want ASAP :)

• emacs
• flatwhite
• kanagawa
• serika_light
• acme
• nord_light
• hex_steel
• hex_toxic
• zenburn
• doom_acario_dark

Correct Example

Here is an example of dark_plus (VS Code theme) which has been updated specifically for #3890:

Need Attention

There follows screen shots of those that seem in need of updates, there maybe more, this is just my opinion. I have tried to add a ping to the authors:

@Yevgnen

[theli-ua]

Is there a way to style gutter symbols separately from patch/diff highlighting?

[David-Else]

@theli-ua No, afraid not, these theme keys were only meant for diff gutters: #3890 (comment)

[Aethrexal]

There we go, Doom Acario have gotten a change.

[pascalkuthe]

Thanks @David-Else for going trough the effort of putting this list together!

[xcdkz]

Acme and Nord Light are merged now 👍

[David-Else]

Acme and Nord Light are merged now +1

Awesome! 6/10 complete... Any update from @Yevgnen @AlexanderBrevig @zetashift @VuiMuich ?

[AlexanderBrevig]

I'll have a look soon. Should maybe be added to the linter if it's not already?

[David-Else]

The linter could check the keys exists, and that they are different, but many of the problems have been caused by a bad choice of colors as there were no diff gutters for visual inspection.

[VuiMuich]

Acme and Nord Light are merged now +1

Awesome! 6/10 complete... Any update from @Yevgnen @AlexanderBrevig @zetashift @VuiMuich ?

Sorry for the delayed response, have been quite offline the past couple days. I am confident to find some time tomorrow at about the same hour to push an update.

[VuiMuich]

Realised it took actually less then anticipated, as the diff-tags were there and just the color choice was bad...

[AlexanderBrevig]

I've made a PR for flatwhite #5036 and a PR for adding the diff to themelint #5037

[David-Else]

@AlexanderBrevig 22.12 came out, you just missed the boat for the flatwhiteupdate getting in it. Great you updated the themelint!

[David-Else]

@Yevgnen Are you able to update the emacs theme in the near future?

Could anyone else maybe fix it? It would be nice to close this issue, we are now at 9/10 :)