-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the suggestion from history in prompt greyed out until activated #4920
Labels
Comments
Hmm or maybe I should just submit the PR first and let the discussion happen that together with the review process? |
Maybe a new theme key that falls back to comment if that key isn't present? |
How about a new theme key |
Maybe |
archseer suggested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Currently the history suggestion in prompts use the same color as any other text (it uses
ui.text
):It can confuse new users as the cursor is place at the beginning of the seemingly active text. Even for experienced users it might not be immediately obvious whether the text is active or not (can only tell from he cursor position).
I suggest we use an alternative color when showing the suggestion. If this is desired, what color should we use? I would suggest using
comment
.If this gets approved I will submit a PR. Thanks!
The text was updated successfully, but these errors were encountered: