Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the suggestion from history in prompt greyed out until activated #4920

Closed
xJonathanLEI opened this issue Nov 28, 2022 · 6 comments · Fixed by #5104
Closed

Make the suggestion from history in prompt greyed out until activated #4920

xJonathanLEI opened this issue Nov 28, 2022 · 6 comments · Fixed by #5104
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements

Comments

@xJonathanLEI
Copy link
Contributor

Currently the history suggestion in prompts use the same color as any other text (it uses ui.text):

image

It can confuse new users as the cursor is place at the beginning of the seemingly active text. Even for experienced users it might not be immediately obvious whether the text is active or not (can only tell from he cursor position).

I suggest we use an alternative color when showing the suggestion. If this is desired, what color should we use? I would suggest using comment.

If this gets approved I will submit a PR. Thanks!

@xJonathanLEI xJonathanLEI added the C-enhancement Category: Improvements label Nov 28, 2022
@xJonathanLEI
Copy link
Contributor Author

Or should a new theme key be created for this? Btw this is how it looks like using comment on the default theme:

image

@kirawi kirawi added the A-theme Area: Theme and appearence related label Nov 28, 2022
@xJonathanLEI
Copy link
Contributor Author

Hmm or maybe I should just submit the PR first and let the discussion happen that together with the review process?

@gabydd
Copy link
Member

gabydd commented Nov 29, 2022

Maybe a new theme key that falls back to comment if that key isn't present?

@xJonathanLEI
Copy link
Contributor Author

How about a new theme key ui.prompt.suggestion?

@gabydd
Copy link
Member

gabydd commented Nov 29, 2022

Maybe ui.prompt.completion your idea is good as well

@xJonathanLEI
Copy link
Contributor Author

archseer suggested ui.text.inactive to be added and used here. Proceeding with that for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants