Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-i doesn't do anything with clangd #4874

Closed
creikey opened this issue Nov 24, 2022 · 4 comments · Fixed by #4961
Closed

Ctrl-i doesn't do anything with clangd #4874

creikey opened this issue Nov 24, 2022 · 4 comments · Fixed by #4961
Labels
C-bug Category: This is a bug

Comments

@creikey
Copy link

creikey commented Nov 24, 2022

Summary

The keymap says it should jump forward on the jumplist, but it doesn't

Reproduction Steps

Type this into helix:

int test() { return 5; }

int main() {
  test();
}
  1. Put cursor over the call to test();
  2. Type gd, cursor jumps to test()
  3. Press Ctrl-o, cursor jumps back to the call to test correctly.
  4. Ctrl-i now should jump forward again in the jump list but it doesn't

Helix log

~/.cache/helix/helix.log
2022-11-23T23:09:20.549 helix_lsp::transport [ERROR] err <- "I[23:09:20.549] <-- textDocument/definition(28)\r\n"
2022-11-23T23:09:20.550 helix_lsp::transport [ERROR] err <- "I[23:09:20.549] --> reply:textDocument/definition(28) 0 ms\r\n"```

</details>


### Platform

Windows 11

### Terminal Emulator

Windows Terminal

### Helix Version

7e99087fa36fd49b350311ebdbc3b9338794746b
@creikey creikey added the C-bug Category: This is a bug label Nov 24, 2022
@archseer
Copy link
Member

#4864 (comment)

@creikey
Copy link
Author

creikey commented Nov 24, 2022

#4864 (comment)

This would be very strange as the same example works fine with neovim

@CptPotato
Copy link
Contributor

It indeed is very strange but I can confirm that Ctrli works in neovim regardless of my terminal emulator configuration. In helix I have to change the config according to the comment linked above.

It's possible that Ctrli sends a different input to the terminal application by default (I think it's Tab) and neovim has a mapping for that which performs the same action as Ctrli. At least on my machine Tab as well as Ctrli both jump forward in neovim.

@creikey
Copy link
Author

creikey commented Nov 24, 2022

It indeed is very strange but I can confirm that Ctrli works in neovim regardless of my terminal emulator configuration. In helix I have to change the config according to the comment linked above.

It's possible that Ctrli sends a different input to the terminal application by default (I think it's Tab) and neovim has a mapping for that which performs the same action as Ctrli. At least on my machine Tab as well as Ctrli both jump forward in neovim.

Wow, tab works as ctrl i for some reason! Lets me go forward after ctrl o in helix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants