Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thread main panicked - after clicking undo #4777

Closed
norregaarden-scalgo opened this issue Nov 16, 2022 · 3 comments
Closed

thread main panicked - after clicking undo #4777

norregaarden-scalgo opened this issue Nov 16, 2022 · 3 comments
Labels
A-core Area: Helix core improvements C-bug Category: This is a bug

Comments

@norregaarden-scalgo
Copy link

Summary

by the way you hit some nice numbers: image

this is the error I got when Helix closed with unsaved changes...

thread 'main' panicked at 'Position 6815 is out of range for changeset len 6814!', helix-core/src/transaction.rs:397:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Reproduction Steps

I tried this:

  1. hx

I expected this to happen:

Instead, this happened:

Helix log

~/.cache/helix/helix.log
please provide a copy of `~/.cache/helix/helix.log` here if possible, you may need to redact some of the lines

Platform

Ubuntu

Terminal Emulator

Alacritty

Helix Version

22.08.1-445-gdf6d0442

@norregaarden-scalgo norregaarden-scalgo added the C-bug Category: This is a bug label Nov 16, 2022
@kirawi kirawi added the A-core Area: Helix core improvements label Nov 16, 2022
@the-mikedavis
Copy link
Member

Do you have a concrete reproduction case that can cause this crash? This particular panic is hard to reproduce.

If you were using window splits, this may be fixed by #4733

@norregaarden-scalgo
Copy link
Author

I do not have a concrete reproduction case that can cause this crash. Honestly I'm not sure if it is even because I clicked undo. Helix has crashed similar to this many times, not only when I didn't know what I clicked, but mostly when I started using Helix a month or two ago, so I reported this because it is now a rare event.

Can I ask, while we're here, is Helix supposed to forget your registers when you close the program? I don't want to type my macros again every time.

I must say, thank you for making this editor, it is fun to follow the project. I really don't mind the lack of plugins and sessions (and saving registers), that simplicity makes it nice. And the selection mode is just what I missed.

Another unrelated thing while we're here: In the beginning, I was quite happy about the keybind menus, but I wanted a menu in the beginning that said which keys open keybind menus, i.e. :, [, g, space. I had FOMO about there being a menu I didn't know about.

I was using vertical window split, but I don't know if it is related.

Thanks again. Just go ahead and close the issue.

@the-mikedavis
Copy link
Member

Since you had a split I think this is #4732. I'll close in favor of that.

is Helix supposed to forget your registers when you close the program?

Persisting state like registers is covered in #401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Helix core improvements C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

3 participants