Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated typescript grammar #4702

Closed
gabydd opened this issue Nov 10, 2022 · 2 comments · Fixed by #4703
Closed

Outdated typescript grammar #4702

gabydd opened this issue Nov 10, 2022 · 2 comments · Fixed by #4703
Labels
A-language-support Area: Support for programming/text languages C-enhancement Category: Improvements

Comments

@gabydd
Copy link
Member

gabydd commented Nov 10, 2022 •
edited
Loading

The current typescript grammar is missing some fixes that are available on the latest grammar. Specifically template literal types had some issues being parsed that messed with highlighting that was fixed in: tree-sitter/tree-sitter-typescript#188.

I will create a pr for this (already have it fixed in a local branch) but I was wondering what are the guidelines for upgrading grammar? Should I update to the latest master or only to the commit that fixes the template literal type highlighting problem I had?
@kirawi
Copy link
Member

kirawi commented Nov 10, 2022

You can update to the latest stable commit, which seems to be 082da44a5263599186dadafd2c974c19f3a73d28

@kirawi kirawi added C-enhancement Category: Improvements A-language-support Area: Support for programming/text languages labels Nov 10, 2022
@gabydd gabydd mentioned this issue Nov 10, 2022
Merged
@gabydd
Copy link
Member Author

gabydd commented Nov 10, 2022

Thanks @kirawi this issue is resolved with #4703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages C-enhancement Category: Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update typescript grammar and queries gabydd/helix
2 participants
@kirawi @gabydd