Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for Janet #4574

Closed
ghost opened this issue Nov 3, 2022 · 3 comments
Closed

add support for Janet #4574

ghost opened this issue Nov 3, 2022 · 3 comments
Labels
A-language-support Area: Support for programming/text languages C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors

Comments

@ghost
Copy link

ghost commented Nov 3, 2022

Please add support for the Janet programming language.
@ghost ghost added the C-enhancement Category: Improvements label Nov 3, 2022
@the-mikedavis the-mikedavis added E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors A-language-support Area: Support for programming/text languages labels Nov 3, 2022
@KittyBorgX KittyBorgX mentioned this issue Nov 6, 2022
Closed
@TrOllOchamO
Copy link

I feel like this is something I could handle !
Disclaimer : I'm a little busy now + it will be my first time using tree-sitter + it would be my first commit ever,
so hope for you it's not urgent x)

@pnelson pnelson mentioned this issue Dec 14, 2023
Merged
@rokf
Copy link

rokf commented May 5, 2024

Syntax highlighting works, so does code formatting using janet-format.

At least one LSP implementation is available - https://github.com/CFiggers/janet-lsp - and it works, I've briefly tested it today. See my comment in #9081 for instructions with some macOS (brew) specifics.

@the-mikedavis
Copy link
Member

I'll close this as resolved by #9081 since we have tree-sitter support for the language now. Feel free to open a PR adding the janet language server if that's working as you say in #9081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for janet language KittyBorgX/helix
3 participants
@rokf @the-mikedavis @TrOllOchamO