Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing is skipped if formatter fails #4308

Closed
desbma opened this issue Oct 16, 2022 · 1 comment
Closed

Writing is skipped if formatter fails #4308

desbma opened this issue Oct 16, 2022 · 1 comment

Comments

@desbma
Copy link

desbma commented Oct 16, 2022

To reproduce, add this in ~/.config/helix/languages.toml:

[[language]]
name = "python"
auto-format = true
formatter =  {command = "/bin/false"}

Then, open any Python file, make some changes, and type :wq!.

This is an important issue, and it can make users lose their changes.

@desbma
Copy link
Author

desbma commented Oct 16, 2022

Never mind, already handled by #3684

@desbma desbma closed this as completed Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant