strings highlighting is not right in nushell scripts

[amtoine]

Summary

hello there 👋 😋

i just have a syntax hightlighting issue with some nushell code 🤔

below is a screenshot of what is happening 👍

🟢 the syntax hightlighting is right
🔵 it starts to shift around the "\nLOG:" string of characters
🔴 it is not right anymore and everything looks like a string, except strings themselves
🟠 the file is correctly identified as a nushell script

Reproduction Steps

1. go to functions.nu around the line with export def-env vcfg

I expect the string highlight to stop at the end of "\nLOG:"

Instead, it continues to the bottom of the file, i.e. the strings and the rest are inverted 😮

Helix log

nothing relevant to report from ~/.cache/helix/helix.log

Platform

Linux 5.19.10-arch1-1

Terminal Emulator

alacritty 0.10.1 ()

Helix Version

(22.08.1-165-g4d4be0e8)

[gavincrawford]

This appears to be an issue with the grammar itself, provided by this repo. In this file specifically, it may have something to do with def-env, which isn't included as a keyword in the query for Nu. See here:

helix/runtime/queries/nu/highlights.scm

Lines 29 to 35 in 9b7f349

	[
	"if"
	"else"
	"let"
	"def"
	"export"
	] @keyword

[amtoine]

This appears to be an issue with the grammar itself, provided by this repo. In this file specifically, it may have something to do with def-env, which isn't included as a keyword in the query for Nu.

ooh yes i see it 😮

i tried to modify my ~/.config/helix/runtime/queries/nu/highlights.scm by writing

[
 "if"
 "else"
 "let"
 "def"
 "export"
 "def-env"
] @keyword

but then the hightlighting is completely gone 🤔

i'm new to tree-sitter and grammar integration to an IDE 😕
should tree-sitter-nu/highlights.scm be directly modified?
and then we should run hx --grammar fetch; hx --grammar build?

[the-mikedavis]

This can't be solved just by modifying the highlights - the syntax tree has an ERROR node indicating that the parser failed to parse some of the code successfully. This will need to be fixed upstream in https://github.com/LhKipp/tree-sitter-nu

[amtoine]

This can't be solved just by modifying the highlights - the syntax tree has an ERROR node indicating that the parser failed to parse some of the code successfully. This will need to be fixed upstream in https://github.com/LhKipp/tree-sitter-nu

okok i see 🤔
i guess i'll see that with the upstream then 😌

[amtoine]

there it is 💪

[amtoine]

according the @LhKipp, LhKipp/tree-sitter-nu#3 has been fixed 👍