Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember themes or set light/dark depending on terminal colorscheme #4011

Closed
txtyash opened this issue Sep 28, 2022 · 6 comments
Closed

Remember themes or set light/dark depending on terminal colorscheme #4011

txtyash opened this issue Sep 28, 2022 · 6 comments
Labels
C-enhancement Category: Improvements R-duplicate Duplicated issue: please refer to the linked issue

Comments

@txtyash
Copy link
Contributor

txtyash commented Sep 28, 2022

If a user hasn't set a theme then reloading the previously set theme on startup would be nice.

Better than that, letting the user set their light theme and a dark theme in config so that if the current terminal theme is light then switch to the light, user preferred theme and vice-versa.

@txtyash txtyash added the C-enhancement Category: Improvements label Sep 28, 2022
@dead10ck
Copy link
Member

If a user hasn't set a theme then reloading the previously set theme on startup would be nice.

If the user wants to persist a theme, then the config file is exactly what this is for.

Better than that, letting the user set their light theme and a dark theme in config so that if the current terminal theme is light then switch to the light, user preferred theme and vice-versa.

Duplicate of #2158

@dead10ck dead10ck closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2022
@txtyash
Copy link
Contributor Author

txtyash commented Sep 28, 2022

If the user wants to persist a theme, then the config file is exactly what this is for.

It's not that the user only wants the exact same theme to persist or be set the entire time. If a user is usually changing themes, say setting they set "gruvbox" now then exited. On restart, the theme should be "gruvbox". Now, the user sets "ayu_dark", exits & restarts, so now theme should be "ayu_dark". This isn't the same as setting a theme in the config.

@dead10ck
Copy link
Member

I would hazard an assumption that most users don't change their themes around that often, once they find one or two that they like. In any case, this could probably be served by #401.

@txtyash
Copy link
Contributor Author

txtyash commented Sep 28, 2022

@dead10ck Coming from a long term use of neovim and interaction with the vim community, I have come across a lot of users that keep changing themes. Not too frequently.

Implementing this doesn't seem hard. A weak implementation would be saving theme to a tmp file or much better saving it to a database. It would be just more convenient.

Better than that, letting the user set their light theme and a dark theme in config so that if the current terminal theme is light then switch to the light, user preferred theme and vice-versa.

To me personally, this sounds really cool & quite useful. #2158 covers it.

@dead10ck
Copy link
Member

Implementing this doesn't seem hard. A weak implementation would be saving theme to a tmp file or much better saving it to a database. It would be just more convenient.

Cool, then I guess we can expect you get involved in the discussion in #401, come up with a concrete plan, and submit a PR.

@txtyash
Copy link
Contributor Author

txtyash commented Sep 28, 2022

@dead10ck Sure, to get involved but can't say anything about a PR.

@the-mikedavis the-mikedavis added the R-duplicate Duplicated issue: please refer to the linked issue label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements R-duplicate Duplicated issue: please refer to the linked issue
Projects
None yet
Development

No branches or pull requests

3 participants