-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember themes or set light/dark depending on terminal colorscheme #4011
Comments
If the user wants to persist a theme, then the config file is exactly what this is for.
Duplicate of #2158 |
It's not that the user only wants the exact same theme to persist or be set the entire time. If a user is usually changing themes, say setting they set "gruvbox" now then exited. On restart, the theme should be "gruvbox". Now, the user sets "ayu_dark", exits & restarts, so now theme should be "ayu_dark". This isn't the same as setting a theme in the config. |
I would hazard an assumption that most users don't change their themes around that often, once they find one or two that they like. In any case, this could probably be served by #401. |
@dead10ck Coming from a long term use of neovim and interaction with the vim community, I have come across a lot of users that keep changing themes. Not too frequently. Implementing this doesn't seem hard. A weak implementation would be saving theme to a tmp file or much better saving it to a database. It would be just more convenient.
To me personally, this sounds really cool & quite useful. #2158 covers it. |
Cool, then I guess we can expect you get involved in the discussion in #401, come up with a concrete plan, and submit a PR. |
@dead10ck Sure, to get involved but can't say anything about a PR. |
If a user hasn't set a theme then reloading the previously set theme on startup would be nice.
Better than that, letting the user set their light theme and a dark theme in config so that if the current terminal theme is light then switch to the light, user preferred theme and vice-versa.
The text was updated successfully, but these errors were encountered: