Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments are highlighted when "#" is part of string literal in *.fish files #3698

Closed
sshilovsky opened this issue Sep 4, 2022 · 0 comments · Fixed by #3704
Closed

comments are highlighted when "#" is part of string literal in *.fish files #3698

sshilovsky opened this issue Sep 4, 2022 · 0 comments · Fixed by #3704
Labels
A-tree-sitter Area: Tree-sitter C-bug Category: This is a bug upstream

Comments

@sshilovsky
Copy link

Summary

In a line echo 123#comment the character # is mistakenly recognized as a comment in *.fish files.

Reproduction Steps

$ echo 'echo 123#comment' > test.fish
$ fish test.fish
123#comment
$ hx test.fish

#comment is highlighted as a comment in the editor, although it's not. (bash highlighter works correctly)

Helix log

~/.cache/helix/helix.log
2022-09-05T02:53:52.835 helix_view::editor [ERROR] Failed to initialize the LSP for `source.fish` { LSP not defined }

Platform

Linux

Terminal Emulator

alacritty 0.10.1 ()

Helix Version

helix 22.08 (ee94031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tree-sitter Area: Tree-sitter C-bug Category: This is a bug upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants