Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code action popup uses ui.popup and ui.menu #3438

Closed
CptPotato opened this issue Aug 15, 2022 · 0 comments · Fixed by #3444
Closed

Code action popup uses ui.popup and ui.menu #3438

CptPotato opened this issue Aug 15, 2022 · 0 comments · Fixed by #3444
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@CptPotato
Copy link
Contributor

This is just a minor nit, but I tried to have a different color for the doc popup (ui.popup) next to the completion list (ui.menu):

image

This works nicely but then the code action popup looks odd because it nests a menu inside a popup:

image

I think the code action popup could use the same layout as the completion list (i.e. removing the border).
@the-mikedavis the-mikedavis added C-enhancement Category: Improvements A-helix-term Area: Helix term improvements labels Aug 15, 2022
@A-Walrus A-Walrus mentioned this issue Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove border from code actions popup A-Walrus/helix
2 participants
@CptPotato @the-mikedavis