Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate entries from theme picker #3354

Closed
ChrHorn opened this issue Aug 8, 2022 · 2 comments · Fixed by #3439
Closed

Remove duplicate entries from theme picker #3354

ChrHorn opened this issue Aug 8, 2022 · 2 comments · Fixed by #3439
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@ChrHorn
Copy link
Contributor

ChrHorn commented Aug 8, 2022

It is possible to overwrite the runtime themes that come with Helix by putting a theme with the same name in the .config/helix/themes directory. This creates duplicate entries in the theme picker that both point to the same theme:

image

Best solution would be just to remove the duplicate entries.

@ChrHorn ChrHorn added the C-enhancement Category: Improvements label Aug 8, 2022
@the-mikedavis the-mikedavis added the A-helix-term Area: Helix term improvements label Aug 8, 2022
@pythoneer
Copy link

I generally agree, but is it that more complicated to maybe have it like

bogster             bogster(user)

To have them both and mark the user theme?

@the-mikedavis
Copy link
Member

the-mikedavis commented Aug 8, 2022

That might be a problem for choosing a theme in your config.toml: do you write theme = "bogster(user)"? It could work but it doesn't seem very elegant.

It looks like both "bogster"s activate same theme (the user one) because of the theme loading rules. I think the simplest way to make this less confusing would be to deduplicate the theme completion but in the long-run we may want to support multiple themes with the same name for the sake of #3067. You may want to make a small modification to a built-in theme locally and name it the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants