Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a File Watcher #3171

Closed
brxken128 opened this issue Jul 23, 2022 · 2 comments
Closed

Implement a File Watcher #3171

brxken128 opened this issue Jul 23, 2022 · 2 comments
Labels
C-enhancement Category: Improvements

Comments

@brxken128
Copy link

I am aware that this is a duplicate, and I apologise for this.

I saw the open PR regarding this feature, #2653, and I was wondering if there's anything we can do to get this implemented? From what I can see, it's a pretty sought-after feature and I wouldn't mind helping out where possible.

The PR looks stale and the user hasn't been active, would it be best to start fresh? I'm sure we can get something suitable from what that user started.

@brxken128 brxken128 added the C-enhancement Category: Improvements label Jul 23, 2022
@brxken128
Copy link
Author

brxken128 commented Jul 23, 2022

From what I can see, things look fine aside from the scattered TODO items, many of which are questions.

EDIT: I haven't actually been able to get that PR working in my testing, which is odd.

@the-mikedavis
Copy link
Member

In general the Matrix Space is a better format for this kind of development discussion.

#2653 is a bit held up since it's in need of review / guidance - it may not be stale on the author's end. You can contribute to their branch on their fork if you'd like to pull it over the finish line and have a good idea of how to go about it, or discuss directly on the PR if the author is still active. You can also pick up their branch and modify it as needed and open a PR to supersede #2653. I would make sure to at least give the original author co-author attribution on commits you re-use/modify though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

2 participants