Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings that require AltGr modifiers don't work on Windows #2914

Closed
CptPotato opened this issue Jun 29, 2022 · 4 comments
Closed

Keybindings that require AltGr modifiers don't work on Windows #2914

CptPotato opened this issue Jun 29, 2022 · 4 comments
Labels
C-bug Category: This is a bug

Comments

@CptPotato
Copy link
Contributor

CptPotato commented Jun 29, 2022

Summary

as mentioned in #595 (comment)

Keybinds that use characters which require the AltGr modifier don't seem to work on windows. Entering these characters normally as text, however, works as expected with the fixes made to address #595.

One example is the pipe command | on some European keyboard layouts.
For reference, crossterm's event-read example registers the key as:
Event: Key(KeyEvent { code: Char('|'), modifiers: CONTROL | ALT })

Another thing to note is that on linux the same keybind works for me (with the same keyboard layout).

Edit: I just tested it on linux: Characters that are written with the AltGr modifier do not include the ˋCONTROLˋ and ˋALTˋ modifier-flags in crossterm, which is probably the cause of this issue.

Helix log

Nothing of interest.

Platform

Windows

Terminal Emulator

Wezterm (nightly), Cmd, Powershell, ConEmu

Helix Version

built from current master 22.05-159-gbf1db737

@CptPotato CptPotato added the C-bug Category: This is a bug label Jun 29, 2022
@CptPotato CptPotato changed the title Keybindings with AltGr modifiers don't work on Windows Keybindings that require AltGr modifiers don't work on Windows Jun 29, 2022
@goyalyashpal
Copy link
Contributor

goyalyashpal commented Jul 23, 2022

hey, so, helix is working for you on wezterm on windows?? I am facing problems with it

@CptPotato
Copy link
Contributor Author

CptPotato commented Jul 23, 2022

hey, so, helix is working for you on wezterm on windows?? I am facing problems with it

Yup, it's working perfectly fine. Note that I'm using cmd not bash (the latter one doesn't work for me; powershell should be fine, too, but I don't use that).

@goyalyashpal
Copy link
Contributor

ahw right... i am using bash, but just tried wezterm --> cmd --> hx ; still showed the same gibberish

@pascalkuthe
Copy link
Member

Closing favor of #7129 since that has more details

@pascalkuthe pascalkuthe closed this as not planned Won't fix, can't repro, duplicate, stale Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

3 participants