Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:wq! messes up the terminal #2863

Closed
Pistahh opened this issue Jun 23, 2022 · 2 comments
Closed

:wq! messes up the terminal #2863

Pistahh opened this issue Jun 23, 2022 · 2 comments
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug

Comments

@Pistahh
Copy link

Pistahh commented Jun 23, 2022

Summary

When I try to edit something I have no permissions for and try to save and exit with :wq!, it exits the editor but leaves the terminal in a messed up state:
image

for reference, this is how it should look like:

image

I use zsh and my prompt is set up by https://github.com/Pistahh/dot-zsh/blob/master/.zsh.d/prompt

Reproduction Steps

I tried this:

  1. hx /etc/hosts as non-root (so no write permissions)
  2. modified it
  3. tried to save and exit with :wq!

I expected this to happen:

terminal is not messed up

Instead, this happened:

terminal is messed up

Helix log

No response

Platform

Linux, zsh.

Terminal Emulator

issue happens both in terminator and Windows Terminal

Helix Version

helix 22.05 (c107f4e)

@Pistahh Pistahh added the C-bug Category: This is a bug label Jun 23, 2022
@the-mikedavis the-mikedavis added the A-helix-term Area: Helix term improvements label Jun 23, 2022
@sbromberger
Copy link
Contributor

I think I've narrowed it down to needing to reset isig (stty isig) on exit.

@dead10ck
Copy link
Member

dead10ck commented Mar 10, 2023

I believe this was fixed with #4081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

4 participants