Changing modes through a keybind that executes multiple commands crashes Helix

[lucypero]

Summary

this mapping crashes Helix:

[keys.normal]
C = ["extend_to_line_end", "change_selection"]

I believe the crash happens when you transition editing modes through a keymap that executes multiple commands.

Output:

thread 'main' panicked at 'not implemented', helix-term\src\ui\editor.rs:1292:34
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

It crashes here in helix-term/src/ui/editor.rs:

self.last_insert.0 = match self.keymaps.get(mode, key) {
                            KeymapResult::Matched(command) => command,
                            // FIXME: insert mode can only be entered through single KeyCodes
                            _ => unimplemented!(),
                        };

Adding this line prevents the crash:

                        self.last_insert.0 = match self.keymaps.get(mode, key) {
                            KeymapResult::Matched(command) => command,
                            KeymapResult::MatchedSequence(commands) => {
                                commands.last().unwrap().clone()
                            }
                            // FIXME: insert mode can only be entered through single KeyCodes
                            _ => unimplemented!(),
                        };

Reproduction Steps

No response

Helix log

~/.cache/helix/helix.log

please provide a copy of `~/.cache/helix/helix.log` here if possible, you may need to redact some of the lines

Platform

Windows

Terminal Emulator

Windows Terminal

Helix Version

22.03-258-gefae7616

[the-mikedavis]

Duplicate of #2051