Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch & build grammars into the source runtime dir in helix-term builder #2023

Closed
the-mikedavis opened this issue Apr 8, 2022 · 1 comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@the-mikedavis
Copy link
Member

Currently the helix-term builder calls out to the same functions as are used in the hx -g fetch and hx -g build CLI options. The CLI options fetch and build grammars into ~/.config/helix/runtime/grammars directory (on unix). This is problematic if one updates their helix installation from source using cargo install and then removes and copies or links the runtime directory from source: the ~/.config/helix/runtime/grammars directory gets deleted and needs to be recreated with manual calls to hx -g fetch and hx -g build.

We should use the source repo's runtime directory when fetching and building grammars in the helix-term builder. Also, as @dead10ck points out on the matrix, it's also not very friendly for a compilation phase to go modify files outside the source directory.

I suspect that #2012 falls under this.

@the-mikedavis the-mikedavis added C-enhancement Category: Improvements A-helix-term Area: Helix term improvements labels Apr 8, 2022
@the-mikedavis
Copy link
Member Author

Fixed by #5411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

1 participant