-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open large diff file is very slow #1865
Comments
This is grammar specific, \cc @the-mikedavis Just to double check, you are compiling helix in release mode via |
I compile it in debug mode and I've tried the release version, the same issue exists. |
The diff file can be generated in the helix repo. git format-patch --stdout v0.4.0..v0.6.0 > test.diff |
Thanks, that helps! I can reproduce it and it seems to affect typing afterwards as well. |
This might fall under #338? I can reproduce the lag by making a similarly large rust file
There might be some improvements to tree-sitter-diff we can make to reduce the number of named nodes but I doubt it would be a noticeable improvement for very large files like these. |
I don't know how treesitter operates exactly, but wouldn't streaming bits of the file to treesitter solve the issue? |
Summary
Open large diff file (about 2M) is very slow, but hx open it quickly when I rename file extension to .txt.
Here is the perf report
Reproduction Steps
No response
Helix log
No response
Platform
Linux
Terminal Emulator
Alacritty 0.11.0 (e7bb6c2)
Helix Version
helix 0.6.0 (22ba668)
The text was updated successfully, but these errors were encountered: