-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ]o
(comment textobject) something else
#1764
Comments
Another issue with making it a symbol is that if someone is trying to select inside a pair of symbols, we preclude them from doing that. It's common enough in the web world for example to use # as the delimiter for a regex string, to avoid having to escape every / in a url pattern. On the other hand I would actually prefer to have # be the binding in normal mode for commenting. |
Just to fill in, |
What about |
IMO same problem as #, it's used as a delimiter for regexes in many languages, and had the meaning of relating to search elsewhere. Between the two I would pick #. I still think a letter is the best option though. |
Another possibility might be too reclaim c for comment, then change the class textobject to something like s for struct, or something. |
I wonder what @sudormrfbin think about it since he chose the keys for class. |
I personally like the current keybinds, both |
Ah, then I guess we should close this issue then since we don't see any better alternatives? |
Personally, I would be for reclaiming |
One advantage to Try this on your keyboard to see which one is faster: |
|
Only problem with # is that it is a shifted key usually, making it harder to quickly use, and breaks the pattern of using a letter for the other textobjects. That said, maybe we open an issue for further discussion?
Originally posted by @EpocSquadron in #1605 (comment)
The issue with
]o
is that it in not intuitive,o
does not have any link to comment, maybe#
will work better I guess, but if we want more consistency, maybe we can changectrl-c
to#
, which makes it similar to other languages. Alternatively/
could be used I think.The text was updated successfully, but these errors were encountered: