Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jumping via search doesn't add to the jumplist #1625

Closed
hubalt opened this issue Feb 7, 2022 · 0 comments · Fixed by #1718
Closed

Jumping via search doesn't add to the jumplist #1625

hubalt opened this issue Feb 7, 2022 · 0 comments · Fixed by #1718
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug E-good-first-issue Call for participation: Issues suitable for new contributors

Comments

@hubalt
Copy link

hubalt commented Feb 7, 2022 •
edited
Loading

Perhaps not a bug. Maybe this behavior was removed intentionally. Easy enough to work around by manually saving the position pre-search to the jumplist. Just thought I'd bring it up since it differs from the vim behavior I'm used to.

Reproduction steps

Open a file, do a couple of successful searches (/abc then /def), ctrl-o does nothing.

Environment

  • Platform: Linux
  • Terminal emulator: Alacritty
  • Helix version: 0.6.0
~/.cache/helix/helix.log 
please provide a copy of `~/.cache/helix/helix.log` here if possible, you may need to redact some of the lines
@hubalt hubalt added the C-bug Category: This is a bug label Feb 7, 2022
@sudormrfbin sudormrfbin added the E-good-first-issue Call for participation: Issues suitable for new contributors label Feb 7, 2022
@kirawi kirawi added the A-helix-term Area: Helix term improvements label Feb 7, 2022
Philipp-M added a commit to Philipp-M/helix that referenced this issue Feb 27, 2022
@Philipp-M
Add jumplist support for the search (closes helix-editor#1625)
44ff7e0
@Philipp-M Philipp-M mentioned this issue Feb 27, 2022
Merged
Philipp-M added a commit to Philipp-M/helix that referenced this issue Mar 1, 2022
@Philipp-M
Add jumplist support for the search (closes helix-editor#1625)
2b3e0db
archseer pushed a commit that referenced this issue Mar 1, 2022
@Philipp-M
Add jumplist support for the search (closes #1625) (#1718)
49c5bc5
@Philipp-M Philipp-M mentioned this issue Jul 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug E-good-first-issue Call for participation: Issues suitable for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add jumplist support for the search (closes #1625) Philipp-M/helix
3 participants
@sudormrfbin @hubalt @kirawi