ui.cursor.primary always overrides ui.cursor.insert

[bbodi]

If ui.cursor.primary is set in a theme, it always overrides e.g. ui.cursor.insert.

E.g. currently in gruvbox theme one can't tell where is the cursor in a selection because it has the same color as the selection:

If I change the ui.cursor.primary value of the theme file, the issue is solved:

However, I also would like to give ui.cursor.insert a different color, so I know if I am in insert mode, but currently it is not possible

[matoous]

I am not sure whether the behavior should be changed 🤔 if the theme specifies different cursor colors for insert/normal mode and doesn't set the primary cursor color this will work fine, maybe we should adjust the theme instead? Or am I missing something?

[bbodi]

Now it is not possible to set a color to normal mode primary cursor, and a different one for insert mode cursor.

[matoous]

But wouldn't that require also having ui.cursor.primary_select and ui.cursor.primary_insert? What should the precedence be, e.g. if I have ui.cursor.primary and ui.cursor.insert if we give precedence to ui.cursor.primary than you can't distinguish between select/insert and other modes. If we give precedence to ui.cursor.insert than we can't distinguish primary vs. additional selections.

[oati]

One solution would be to make ui.cursor.insert only apply to the primary cursor when ui.cursor.primary is present.