Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent "variable.parameter" highlighting #12038

Open
pithecantrope opened this issue Nov 8, 2024 · 2 comments
Open

Inconsistent "variable.parameter" highlighting #12038

pithecantrope opened this issue Nov 8, 2024 · 2 comments
Labels
A-language-support Area: Support for programming/text languages C-bug Category: This is a bug

Comments

@pithecantrope
Copy link

Summary

I was working on my colorscheme and noticed this bug:
C: 2024-11-09-013255_511x93_scrot
Python: 2024-11-09-013906_367x56_scrot
The same problem occurs in Cpp also. I believe that highlights.scm is the cause of problem.

Reproduction Steps

I tried this:

"variable" = { fg = "text" }
"variable.parameter" = { fg = "fire", modifiers = ["italic"] }

Helix log

No response

Platform

Linux

Terminal Emulator

st 0.9.2

Installation Method

pacman -S helix

Helix Version

helix 24.07

@pithecantrope pithecantrope added the C-bug Category: This is a bug label Nov 8, 2024
@pithecantrope
Copy link
Author

pithecantrope commented Nov 12, 2024

2024-11-12-235917_474x385_scrot
Theme: tokyonight. Just wrong highlight for "variable.parameter"

@the-mikedavis
Copy link
Member

This is a highlights issue but it's caused by a lack of locals.scm queries rather than a bug in the highlights.scm. locals.scm marks definitions and references of locals like parameters so that the highlighter can theme them the same. Python has a locals.scm query while C and C++ don't.

The screenshot in the second message is probably showing #1151

@the-mikedavis the-mikedavis added the A-language-support Area: Support for programming/text languages label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

2 participants