Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gutters more configurable #1188

Closed
dannasessha opened this issue Nov 29, 2021 · 7 comments
Closed

Make gutters more configurable #1188

dannasessha opened this issue Nov 29, 2021 · 7 comments
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@dannasessha
Copy link
Contributor

dannasessha commented Nov 29, 2021

Following up on #783.

Gutters are potentially useful for a variety of purposes, we should make them more configurable.

from previous comments : "...if a user wanted to use the column in the editor to have a git diff type display ala the vim git gutter plugin, or a git annotate type feature to familiarize themselves with the history of a file from a certain perspective, or even possibly being able to manipulate the column directly for some kind of bespoke user-annotation that could be made on the fly."

and : "...these types of gutter components give us more flexibility to allow for configuring the gutter (like disabling line numbers) or using different gutters per document (for example getting rid of diagnostics on docs with no LSP) as well as defining new types of gutters in the future (i.e. git gutter)"

@dannasessha dannasessha added the C-enhancement Category: Improvements label Nov 29, 2021
@archseer
Copy link
Member

I was thinking the config could be a gutters = ["diagnostic", "line_number"] type array.

@archseer
Copy link
Member

Then you could have a gutter.diagnostic section for any additional config of each component

@kirawi kirawi added the A-helix-term Area: Helix term improvements label Nov 30, 2021
@dannasessha
Copy link
Contributor Author

Okay, I'll see if I can get something going, thank you for the feedback!

@cyruseuros
Copy link

+1 for disabling line numbers as a feature (Or is this possible now? - I wasn't able to find the config option). In an editor which supports jumping to lines this easily they're kind of a waste of space (unless you're screen sharing and talking about the code)

@the-mikedavis
Copy link
Member

#1967 addressed the configuration part of this.

@David-Kunz
Copy link
Contributor

What's still missing in #1967 is configuring the features of each gutter (what e.g. gutter.diagnostic would allow).

@pascalkuthe
Copy link
Member

pascalkuthe commented Apr 4, 2024

Gutters a re pretty flexible now, this issue is old and too general so I am closing it. If you are missing some specific gutter config open a new issue for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants