ecma scm doesn't map private properties to highlight scopes

[mesmere]

Summary

The official JavaScript tree-sitter highlights private properties in ES6 classes as:

	Scopes
Private fields:	... field_definition, private_property_identifier
Private methods:	... method_definition, private_property_identifier

However, in Helix these aren't syntax highlighted and :tree-sitter-highlight-name reveals that they get no highlight scope at all.

• Private fields should get the variable.other.member highlight (like public fields do).
• Private methods should get the function highlight (like public methods do).

Reproduction Steps

Code:

class MyClass {
  field;
  method() {
    return;
  }

  #privateField;
  #privateMethod() {
    return;
  }
}

Screenshot:

Helix log

No response

Platform

arch

Terminal Emulator

foot 1.17.2

Installation Method

manjaro pacman repo

Helix Version

helix 24.3

[mesmere]

It looks like someone else took a crack at this already with #10554 but something's clearly broken.

[David-Else]

Private fields should get the variable.other.member highlight (like public fields do).
Private methods should get the function highlight (like public methods do).

This seems to already be the case, at least in helix 24.7 (cfe80acb). I am using the dark_plus theme.

Please update your Helix.

[the-mikedavis]

Yeah #10554 fixed this but you're on 24.03. If you update to 24.07 you should see that highlighting

[mesmere]

Oh, I'm sorry. I feel silly :X