Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVN workspace support #11403

Closed
seanbone opened this issue Aug 2, 2024 · 3 comments · Fixed by #11429
Closed

SVN workspace support #11403

seanbone opened this issue Aug 2, 2024 · 3 comments · Fixed by #11429
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors

Comments

@seanbone
Copy link

seanbone commented Aug 2, 2024

I'm working on Fortran projects under SVN (I know, right?). The fortls server works a charm, however, with Helix I run in to the issue of workspace root detection. Helix doesn't seem to treat .svn folders as workspace-root markers and so by default it uses my home directory (which in turn causes fortls to time out because it's too much stuff).

After a lot of tinkering and looking at verbose logs, I was able to get it to work as desired in one of two ways:

  1. Adding an empty .helix or .git directory to the workspace root. I seem to recall reading about this in the documentation a while ago, but I can't seem to find it any more. Is there a docs page that states exactly how the workspace root is determined by Helix? It would be helpful for this sort of debugging.
  2. Using the roots option in the Fortran language in languages.toml: roots = [".fortls.json", ".svn"]. Works, but is limited to the Fortran language.

Neither of these solutions is ideal. It requires extra configuration steps either per language or per repository. As far as I can tell, this is not configurable in a generic way at the moment. Personally, the real strength of Helix over, eg, nvim, is that it "just works" most of the time.

I propose adding .svn as a criterion for workspace root detection. I would also be willing to provide a MR if given some pointers as to where in the codebase this happens.

@seanbone seanbone added the C-enhancement Category: Improvements label Aug 2, 2024
@kirawi
Copy link
Member

kirawi commented Aug 2, 2024

What version of Helix are you using? Svn is already recognized as a default root.

@kirawi
Copy link
Member

kirawi commented Aug 3, 2024

I took a look and I was confusing this with #10536.

@kirawi kirawi added E-easy Call for participation: Experience needed to fix: Easy / not much A-helix-term Area: Helix term improvements E-good-first-issue Call for participation: Issues suitable for new contributors labels Aug 3, 2024
@seanbone
Copy link
Author

seanbone commented Aug 3, 2024

I'm using a build based on master from a few months ago (I don't have the exact commit hash at hand).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants