Theme Toml not allowing Bare keys

[Conando025]

Summary

When writing a theme using bare keys / table names leads to malfunction.
The spec says that

Best practice is to use bare keys except when absolutely necessary.

Reproduction Steps

I tried this:

1. create the file ~/.config/helix/theme/broken.tomlwith the following content

[ui.selection]
bg = "black"

2. open helix and type :theme broken

I expected this to happen:

It loads my theme as it would if it was

["ui.selection"]
bg = "black"

Also

# Works
"ui.selection" = { bg = "black" }
# Broken
ui.selection = { bg = "black" }

Instead, this happened:
It refused to load my theme as ui.selection is missing.

Helix log

~/.cache/helix/helix.log

please provide a copy of `~/.cache/helix/helix.log` here if possible, you may need to redact some of the lines

Platform

Linux

Terminal Emulator

alacritty 0.12.2

Installation Method

apt

Helix Version

helix 24.3 (2cadec0)

[the-mikedavis]

This is the intended behavior. We use . for fallback behavior - ui.statusline.inactive falls back to ui.statusline if not defined, and that falls back to ui if not defined. That conflicts with TOML using it for nesting keys so you need to quote your theme keys. In the long run we will switch away from TOML for config including themes (#10389) so we won't be changing how the theme keys work for the sake of TOML