Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement buffer completer #1043

Closed
cole-h opened this issue Nov 9, 2021 · 0 comments · Fixed by #1134
Closed

Implement buffer completer #1043

cole-h opened this issue Nov 9, 2021 · 0 comments · Fixed by #1134
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much

Comments

@cole-h
Copy link
Contributor

cole-h commented Nov 9, 2021

I noticed that there is no buffer completer implemented yet -- is this because of the space menu's buffer picker? Would a buffer completer be accepted if I hypothetically contributed it some time in the future?

Originally posted by @cole-h in #1035 (comment)

That would be great! I think we had no commands that took a buffer before. I also wasn't sure, should we allow specifying buffers by path, or by an ID (or both)? After e2560f4 it's now possible to get the actual numeric ID, and we could display it in the buffer picker too.

@kirawi kirawi added A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much labels Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants